Github user sabhyankar commented on the pull request:
https://github.com/apache/spark/pull/8241#issuecomment-135881841
Hi @mengxr The current approach of rebroadcasting on every predict
broadcasts the entire model and so I suppose the first issue you identified
also applies to the current approach. Currently the trait doesnt have a
limitation on where it can be mixed-in (except the private to spark) and the
type of object it can broadcast. So I suppose we can broadcast multiple objects
as a tuple if needed. I agree that given that models are mutable, preventing a
rebroadcast via this PR will prevent RDD changes to be seen. However, given the
Jira req I assumed that this was ok. Let me know if that is not the case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
