Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8241#issuecomment-135895566
@sabhyankar Yes, the first issue also applies to the current approach. But
I was expecting to solve it with this effort (broadcast less and only once). It
is awkward to declare class with `Broadcastable[(Double, Array[Double],
Vector)]`. It doesn't provide much information but makes the code a little hard
to read.
Issue 3 is actually the most important one because it changes the behavior.
A safer approach would be making a new class for `NaiveBayesModel` with
immutable (or by-contract immutable) data, which only needs broadcast once.
This definitely requires more discussion before we make the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
