Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1102#discussion_r13844551
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala ---
@@ -57,43 +57,54 @@ private[spark] class ApplicationPage(parent:
MasterWebUI) extends WebUIPage("app
})
val executorHeaders = Seq("ExecutorID", "Worker", "Cores", "Memory",
"State", "Logs")
- val executors = app.executors.values.toSeq
- val executorTable = UIUtils.listingTable(executorHeaders, executorRow,
executors)
+ val allExecutors = (app.executors.values ++
app.removedExecutors).toSet.toSeq
--- End diff --
Mm, if we're going to use ExecutorInfo in a Set, we should at least
implement equals() and hashCode() [and toString()?] in case it later actually
comes into play. Both can probably just be based on the pre-existing fullId
field. Or could make it a case class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
