Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1102#discussion_r13844576
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/master/ui/ApplicationPage.scala ---
    @@ -57,43 +57,54 @@ private[spark] class ApplicationPage(parent: 
MasterWebUI) extends WebUIPage("app
         })
     
         val executorHeaders = Seq("ExecutorID", "Worker", "Cores", "Memory", 
"State", "Logs")
    -    val executors = app.executors.values.toSeq
    -    val executorTable = UIUtils.listingTable(executorHeaders, executorRow, 
executors)
    +    val allExecutors = (app.executors.values ++ 
app.removedExecutors).toSet.toSeq
    +    val executors = allExecutors.filter { exec =>
    --- End diff --
    
    Perhaps we could name this something else, now that it needs to be 
differentiated from removedExecutors / allExecutors. Perhaps also a comment on 
why we are retaining EXITED executors (unless you have a particularly excellent 
name in mind).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to