Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/560#discussion_r13860204
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -386,12 +388,31 @@ trait ClientBase extends Logging {
     object ClientBase extends Logging {
       val SPARK_JAR: String = "__spark__.jar"
       val APP_JAR: String = "__app__.jar"
    -  val LOG4J_PROP: String = "log4j.properties"
    -  val LOG4J_CONF_ENV_KEY: String = "SPARK_LOG4J_CONF"
       val LOCAL_SCHEME = "local"
    +  val CONF_SPARK_JAR = "spark.yarn.jar"
    +  val CONF_SPARK_USER_JAR = "spark.yarn.user.jar"
       val CONF_SPARK_YARN_SECONDARY_JARS = "spark.yarn.secondary.jars"
    --- End diff --
    
    adding a comment here about what spark.yarn.secondary.jars is would be nice 
too if you don't mind. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to