Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/560#discussion_r13864023
  
    --- Diff: 
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
    @@ -342,24 +352,16 @@ trait ClientBase extends Logging {
           sparkConf.set("spark.driver.extraJavaOptions", opts)
         }
     
    +    // Forward the Spark configuration to the application master / 
executors.
         // TODO: it might be nicer to pass these as an internal environment 
variable rather than
         // as Java options, due to complications with string parsing of nested 
quotes.
    -    if (args.amClass == classOf[ExecutorLauncher].getName) {
    -      // If we are being launched in client mode, forward the spark-conf 
options
    -      // onto the executor launcher
    -      for ((k, v) <- sparkConf.getAll) {
    -        javaOpts += "-D" + k + "=" + "\\\"" + v + "\\\""
    --- End diff --
    
    Note that this change breaks backwards compatibility with being able to set 
SPARK_JAVA_OPTS to include configs. I would rather not change it in this pr as 
it will take more investigation and testing to make sure it doesn't break 
anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to