Github user vinodkc commented on a diff in the pull request:
https://github.com/apache/spark/pull/8565#discussion_r38522537
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala
---
@@ -278,7 +278,8 @@ class DenseMatrix @Since("1.3.0") (
}
override def hashCode: Int = {
- com.google.common.base.Objects.hashCode(numRows : Integer, numCols:
Integer, toArray)
+ val state = Seq(numRows, numCols, Arrays.hashCode(values),
isTransposed.hashCode)
--- End diff --
I've asked on breeze mailing list and waiting for their reply.
Also I checked breeze CSCMatrix '==' method implementation , it seems '=='
uses the input data we passed from SparseMatrix and just hashCode is not
implemented. I think this will guarantee that my hashCode implementation will
be consistent with Breeze '=='.
All MLlib equals hashCode test cases are passing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
