Github user vinodkc commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8565#discussion_r38609166
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala 
---
    @@ -278,7 +278,8 @@ class DenseMatrix @Since("1.3.0") (
       }
     
       override def hashCode: Int = {
    -    com.google.common.base.Objects.hashCode(numRows : Integer, numCols: 
Integer, toArray)
    +    val state = Seq(numRows, numCols, Arrays.hashCode(values), 
isTransposed.hashCode)
    --- End diff --
    
    Got confirmation from Breeze mailing list that it is an issue and suggested 
to me to raise an issue in Breeze => 
https://github.com/scalanlp/breeze/issues/440
    Can you please suggest whether we need to wait for Breeze issue fix or 
change equals method of CSCMatrix & DenseMatrix to match my  hashCode 
implementation?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to