Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7910#discussion_r38534445
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -48,7 +49,13 @@ private[ui] class ExecutorThreadDumpPage(parent:
ExecutorsTab) extends WebUIPage
val time = System.currentTimeMillis()
val maybeThreadDump = sc.get.getExecutorThreadDump(executorId)
- val content = maybeThreadDump.map { threadDump =>
+ val grepExp =
Option(request.getParameter("grepexp")).map(Pattern.compile(_,
Pattern.MULTILINE))
+
+ val filteredContent = maybeThreadDump.map { threadDump =>
+ threadDump.filter(thread =>
+ grepExp.map { grep =>
grep.matcher(thread.stackTrace).find()}.getOrElse(true)
+ )
--- End diff --
this is not a big deal at all, considering its just for a small number of
threads, but I realize now that we can pull the Option handling up higher, to
completely skip the filter if there is no grep
```scala
grepExp.map { grep =>
threadDump.filter { thread => grep.matcher(thread.stackTrace).find() }
}.getOrElse(threadDump)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
