Github user squito commented on the pull request:
https://github.com/apache/spark/pull/7910#issuecomment-137105507
thanks for bumping this up @andrewor14 . Overall this is an awesome
addition. I just found one usability issue: after I run a grep, the text is
cleared in the grep textfield. I think it would be much better to keep the
same text there (so the user can see what they grepped for, and also to make it
easy to modify it). Not a major issue, but seems worth getting right before we
merge.
The rest of my comments are all pretty minor, I don't think its a big deal
either way.
Can I ask for a bit of general help on how to test out UI changes?
Normally I just run `~compile` in an sbt session, and in another shell I run
`export SPARK_PREPEND_CLASSES=1; bin/spark-shell`. But that doesn't update the
static resources for the UI. I had to manually `cp
core/src/main/resources/org/apache/spark/ui/static/
core/target/scala-2.10/classes/org/apache/spark/ui/`. Which I guess isn't
terrible, just took me a minute to figure out. Is there a better way, ideally
to get those resources copied automatically? (And is it worth documenting on
https://cwiki.apache.org/confluence/display/SPARK/Useful+Developer+Tools)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
