Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8389#discussion_r38592348
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/test/TestHive.scala ---
    @@ -51,6 +51,11 @@ object TestHive
             // SPARK-8910
             .set("spark.ui.enabled", "false")))
     
    +trait TestHiveSingleton {
    +  protected def sqlContext: SQLContext = TestHive
    +  protected def hiveContext: HiveContext = TestHive
    --- End diff --
    
    alternatively if you make this extend `SQLTestUtils` then subclasses can 
just `import testImplicits._`, which is more consistent with other test suites.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to