Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8389#issuecomment-137262771
Hi @marmbrus @cloud-fan all my comments are minor and this is mergeable as
is, but I have two high level comments:
(1) I think we should always put `with TestHiveSingleton` at the end to
make it really explicit that this is where `sqlContext` comes from. Otherwise
it's less clear.
(2) Could we make `TestHiveSingleton` extend `SQLTestUtils`? Then all
subclasses can just `import testImplicits._` if needed, which is more
consistent with the existing test suites. In general it might simplify things
if all SQL tests extend `SQLTestUtils` if they use a `SQLContext`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
