Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38593540
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -781,4 +808,117 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
.forall(x => x(0) >= x(1)))
}
+
+ test("binary logistic regression with weighted samples") {
--- End diff --
This will be hard since it's not easy to reproduce the same dataset in R
given different random generator implementation. But I don't think we need to
compare with R's glmnet here since we are comparing against with our spark
glmnet implementation without weighted feature, and that has been verified
against R.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
