Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/7884#discussion_r38605369
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -803,13 +829,17 @@ private class LogisticAggregator(
this
}
- def count: Long = totalCnt
-
- def loss: Double = lossSum / totalCnt
+ def loss: Double = {
+ require(weightSum >= 1.0, s"The effective number of samples should be
" +
--- End diff --
@rotationsymmetry This definition requires sum of weights == 1. I was
originally thinking about to use this definition, but that will not be
compatible with unbiased version as @mengxr pointed out. What users want may be
weight=2 means this instance appears in the training dataset twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
