Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8476#discussion_r38745663
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
 ---
    @@ -58,6 +61,9 @@ case class ScriptTransformation(
     
       override def otherCopyArgs: Seq[HiveContext] = sc :: Nil
     
    +  private val _broadcastedHiveConf = this.
    +    sc.sparkContext.broadcast(new SerializableConfiguration(sc.hiveconf))
    --- End diff --
    
    You probably don't need broadcasting here. `SerializableConfiguration` 
already avoids reading XML files while deserializing `Configuration` instances. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to