Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/8476#discussion_r38745795
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
---
@@ -290,7 +300,9 @@ case class HiveScriptIOSchema (
outputSerdeClass: Option[String],
inputSerdeProps: Seq[(String, String)],
outputSerdeProps: Seq[(String, String)],
- schemaLess: Boolean) extends ScriptInputOutputSchema with
HiveInspectors {
+ schemaLess: Boolean,
+ recordWriter: String,
+ recordReader: String) extends ScriptInputOutputSchema with
HiveInspectors {
--- End diff --
Use `Option[String]` instead of `String` for `recordWriter` and
`recordReader`, and don't use empty string as their default value in other
places of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
