Github user rotationsymmetry commented on the pull request:
https://github.com/apache/spark/pull/8022#issuecomment-137871809
@feynmanliang Thank you for your comments. I have revised the PR, including
* Refactor: timeUnit has its own setter.
* Add @Since.
* Clean up ScalaDoc.
As I am rewriting the ScalaDoc, it appears that the algorithm can be more
easily described and understood if we use the parameter RetentionFactor (aka,
1- decayFactor) instead of decayFactor. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]