Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8022#discussion_r38806603
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/StreamingLogisticRegressionWithSGD.scala
---
@@ -101,4 +107,14 @@ class StreamingLogisticRegressionWithSGD
private[mllib] (
this.model = Some(algorithm.createModel(initialWeights, 0.0))
this
}
+
+ override def setDecayFactor(decayFactor: Double): this.type = {
--- End diff --
Oh, I meant that you could remove these setters entirely
```scala
scala> trait Superclass { def test: this.type = this }
defined trait Superclass
scala> class Subclass extends Superclass
defined class Subclass
scala> (new Subclass).test
res1: Subclass = Subclass@b364520
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
