Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38927289
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/CartesianProduct.scala
---
@@ -28,9 +28,17 @@ import org.apache.spark.sql.execution.metric.SQLMetrics
* :: DeveloperApi ::
*/
@DeveloperApi
-case class CartesianProduct(left: SparkPlan, right: SparkPlan) extends
BinaryNode {
+case class CartesianProduct(
+ left: SparkPlan,
+ right: SparkPlan,
+ buildSide: BuildSide) extends BinaryNode {
--- End diff --
I am not so sure if the change necessary, as if either side of the table is
small enough, we will resort to the `BroadcastNestedLoopJoin`; since both side
tables are bigger enough, the change may not improve the performance as we
expected.
BTW, we didn't build hash map in CaresianProduct, using `buildSide` seems a
little confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
