Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7417#discussion_r38992905
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -267,12 +267,32 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
}
object CartesianProduct extends Strategy {
+ def createCartesianProduct(left: LogicalPlan, right: LogicalPlan):
SparkPlan = {
--- End diff --
instead of creating a new function, i think it would be clearer if you just
inline the CanBroadcast matching into the rule itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
