Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r39097818
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -101,6 +139,32 @@ private[spark] abstract class YarnSchedulerBackend(
           
ThreadUtils.newDaemonCachedThreadPool("yarn-scheduler-ask-am-thread-pool")
         implicit val askAmExecutor = 
ExecutionContext.fromExecutor(askAmThreadPool)
     
    +    private[YarnSchedulerBackend] def handleExecutorDisconnectedFromDriver(
    +        executorId: String,
    +        executorRpcAddress: RpcAddress): Unit = {
    +      amEndpoint match {
    +        case Some(am) =>
    +          val lossReasonRequest = GetExecutorLossReason(executorId)
    +          val future = am.ask[ExecutorLossReason](lossReasonRequest, 
askTimeout)
    +          future onSuccess {
    +            case reason: ExecutorLossReason => {
    +              
driverEndpoint.askWithRetry[Boolean](RemoveExecutor(executorId, reason))
    +            }
    +          }
    +          future onFailure {
    +            case NonFatal(e) => {
    +              logWarning(s"Attempted to get executor loss reason" +
    +                s" for executor id ${executorId} at RPC address 
${executorRpcAddress}," +
    +                s" but got no response. Marking as slave lost.", e)
    +              
driverEndpoint.askWithRetry[Boolean](RemoveExecutor(executorId, SlaveLost()))
    +            }
    --- End diff --
    
    this actually swallows fatal exceptions. Unfortunately you need to add a
    ```
    case t => throw t
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to