Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8007#issuecomment-139052729
@mccheah @vanzin I think for this patch we can proceed without fixing the
race condition. It may actually turn out to be something that's important to
fix, since the window is not only 1 RT between the driver and the AM, but also
the scheduling delay between each interval on the AM. At the very least we
should file a JIRA and add a TODO comment here that links to that JIRA.
Would you have time to address that issue as well? It may actually not be
super hard to fix. We just need some kind of blacklist that we add to when
`onDisconnected` is called. Then we'll remove the executors from the blacklist
as soon as the future finishes.
As for this patch, once you address the comments I think it's basically
ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
