Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8606#issuecomment-139056656
@davies sorry, not sure I follow.
`millisToDays` seems to not need the check, so I'll remove it. I didn't
find any code path that started from user code. But `fromJavaTimestamp` is
called from user code - the you convert an `RDD[Row]` to a `DataFrame`. I think
it's better to fail early in that case.
The check in `toJulianDay` should be rarely invoked, and might be even
unnecessary given the current limits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
