Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8606#discussion_r39104303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -193,9 +203,14 @@ object DateTimeUtils {
*/
def toJulianDay(us: SQLTimestamp): (Int, Long) = {
val seconds = us / MICROS_PER_SECOND
- val day = seconds / SECONDS_PER_DAY + JULIAN_DAY_OF_EPOCH
- val secondsInDay = seconds % SECONDS_PER_DAY
- val nanos = (us % MICROS_PER_SECOND) * 1000L
+ var day = seconds / SECONDS_PER_DAY + JULIAN_DAY_OF_EPOCH
+ var secondsInDay = seconds % SECONDS_PER_DAY
+ var nanos = (us % MICROS_PER_SECOND) * 1000L
+ if (us < 0) {
+ day -= 1
+ secondsInDay += SECONDS_PER_DAY
+ nanos += (SECONDS_PER_DAY * MICROS_PER_SECOND * 1000L)
--- End diff --
This is not correct, it should be:
```
val julian_us = us + JULIAN_DAY_OF_EPOCH * MICROSECONDS_PER_DAY
val day = julian_us / MICROSECONDS_PER_DAY
val micros = julian_us % MICROSECONDS_PER_DAY
(day.toInt, micros * 1000L
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
