Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39224515
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -214,10 +216,10 @@ public int getPartition(Object key) {
Assert.assertTrue(repartitioned.partitioner().isPresent());
Assert.assertEquals(repartitioned.partitioner().get(), partitioner);
List<List<Tuple2<Integer, Integer>>> partitions =
repartitioned.glom().collect();
- Assert.assertEquals(partitions.get(0), Arrays.asList(new
Tuple2<Integer, Integer>(0, 5),
- new Tuple2<Integer, Integer>(0, 8), new Tuple2<Integer,
Integer>(2, 6)));
- Assert.assertEquals(partitions.get(1), Arrays.asList(new
Tuple2<Integer, Integer>(1, 3),
- new Tuple2<Integer, Integer>(3, 8), new Tuple2<Integer,
Integer>(3, 8)));
+ Assert.assertEquals(partitions.get(0), Arrays.asList(new Tuple2<>(0,
5),
--- End diff --
This looks a little odd since it mixes two different indentation /
alignment styles. In these cases I tend to prefer something like this:
Assert.assertEquals(partitions.get(0),
Arrays.asList(new Tuple2<>(0, 5), new Tuple2<>(0, 8), new Tuple2<>(2,
6)));
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
