Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39256157
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1818,26 +1815,25 @@ public Integer call(String s) throws Exception {
// InputStream functionality is deferred to the existing Scala tests.
@Test
public void testSocketTextStream() {
- JavaReceiverInputDStream<String> test =
ssc.socketTextStream("localhost", 12345);
+ ssc.socketTextStream("localhost", 12345);
}
- @Test
- public void testSocketString() {
-
- class Converter implements Function<InputStream, Iterable<String>> {
--- End diff --
Declaring classes inside methods is super weird in Java, to me, even if
it's allowed. It seemed clearer to establish it as a simple static inner class.
I guess I'm not even clear it needs to be non-anonymous, and so on reflection,
maybe it just can be an anonymous inner class, which is not weird.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
