Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8710#discussion_r39238759
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -348,10 +348,27 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
// Thread Local variable that can be used by users to pass information
down the stack
private val localProperties = new InheritableThreadLocal[Properties] {
- override protected def childValue(parent: Properties): Properties =
new Properties(parent)
--- End diff --
@andrewor14 I'm thinking maybe we should not use `new Properties(parent)`
here. Instead, always copy the parent's Properties to the child's Properties.
Do you think if the child thread needs to see the further changes to the parent
thread's Properties after creating?
This is really confusing when using `Executor` like `ForkJoinPool`, in
which thread A creates thread B but thread B is not a child of thread A. But
thread B still can see the changes in thread A.
/cc @jerryshao since you added this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
