Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8710#discussion_r39242391
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -348,10 +348,27 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
// Thread Local variable that can be used by users to pass information
down the stack
private val localProperties = new InheritableThreadLocal[Properties] {
- override protected def childValue(parent: Properties): Properties =
new Properties(parent)
--- End diff --
I see. However, `new Properties(parent)` keeps a reference to parent rather
than copying them. So If we make any change to the parent thread's properties
after creating the child thread, the child thread will see them.
Is it necessary that the child thread keeps track of the following updates
of the parent thread's properties? I think copying them would be more
reasonable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
