Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8714#discussion_r39254790
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -278,9 +278,24 @@ private[deploy] class Master(
execOption match {
case Some(exec) => {
val appInfo = idToApp(appId)
+ val oldState = exec.state
exec.state = state
- if (state == ExecutorState.RUNNING) { appInfo.resetRetryCount() }
+
+ if (state == ExecutorState.RUNNING) {
+ assert(oldState == ExecutorState.LOADING,
--- End diff --
Does `assert` do much the same as `require` in Scala? just making sure this
isn't a Java-style `assert` underneath.
Does this cause the master to fail then if the state transitions happen out
of order? I pretty much agree that ignoring it isn't good either, but is this
fixing the problem? For example if you get `RUNNING` after `LAUNCHING`, you can
assume `LOADING` happened, and ignore subsequent `LOADING` messages instead? or
does that make more problems?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
