Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8714#discussion_r39254806
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -278,9 +278,24 @@ private[deploy] class Master(
           execOption match {
             case Some(exec) => {
               val appInfo = idToApp(appId)
    +          val oldState = exec.state
               exec.state = state
    -          if (state == ExecutorState.RUNNING) { appInfo.resetRetryCount() }
    +
    +          if (state == ExecutorState.RUNNING) {
    +            assert(oldState == ExecutorState.LOADING,
    +              s"executor $execId state transfer from $oldState to RUNNING 
is illegal")
    +            appInfo.resetRetryCount()
    +          }
    +
               exec.application.driver.send(ExecutorUpdated(execId, state, 
message, exitStatus))
    +
    +          if (state == ExecutorState.LOADING) {
    +            assert(oldState == ExecutorState.LAUNCHING,
    +              s"executor $execId state transfer from $oldState to LOADING 
is illegal")
    +            exec.application.driver.send(
    --- End diff --
    
    Nice, so the driver only is told that the executor is running once the 
master thinks it is now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to