Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/8755#issuecomment-140243693
  
    Hi @davies , I think the idea of only transform expressions that defined in 
`expressions` is not good enough. The key problem I see is we are using 
`Attribute` to represent the output name and type. However, the type info is 
already in `generator.elementTypes` and we only need names, i.e. use 
`Seq[String]` instead of `Seq[Arrtibute]` for `generatorOutput`.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to