Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8755#discussion_r39544824
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -115,8 +114,8 @@ abstract class QueryPlan[PlanType <:
TreeNode[PlanType]] extends TreeNode[PlanTy
}
def recursiveTransform(arg: Any): AnyRef = arg match {
- case e: Expression => transformExpressionUp(e)
- case Some(e: Expression) => Some(transformExpressionUp(e))
+ case e: Expression if expressions.contains(e) =>
transformExpressionUp(e)
+ case Some(e: Expression) if expressions.contains(e) =>
Some(transformExpressionUp(e))
--- End diff --
Good question, ResolveReferences only uses transformExpressionsUp, also
Generate is the only special case that need it. So it's enough for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
