Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8763#discussion_r39551037
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -230,12 +251,16 @@ class NewHadoopRDD[K, V](
super.persist(storageLevel)
}
-
- def getConf: Configuration = confBroadcast.value.value
}
private[spark] object NewHadoopRDD {
/**
+ * Configuration's constructor is not threadsafe (see SPARK-1097 and
HADOOP-10456).
+ * Therefore, we synchronize on this lock before calling new
Configuration().
+ */
+ val CONFIGURATION_INSTANTIATION_LOCK = new Object()
--- End diff --
If `HADOOP-10456` is still an issue then I think that we need to be locking
on the _same_ lock in both NewHadoopRDD and HadoopRDD. Therefore, I'd be in
favor of moving this lock to SparkHadoopUtil or a similar location, then
updating both RDD implementations to use that lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
