Github user mingyukim commented on a diff in the pull request:
https://github.com/apache/spark/pull/8763#discussion_r39560543
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -230,12 +251,16 @@ class NewHadoopRDD[K, V](
super.persist(storageLevel)
}
-
- def getConf: Configuration = confBroadcast.value.value
--- End diff --
Hmm.. ok. What do you think about keeping the public getConf as is and
create a protected "getOptionallyClonedConf" that does cloning optionally based
on the flag? However, the downside is that it's vulnerable to human mistakes in
the future when someone accidentally uses getConf as opposed to
getOptionallyClonedConf for computation. I'm slightly inclined to the
getOptionallyClonedConf route for the possible backcompat break.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
