Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8564#discussion_r39679985
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala 
---
    @@ -460,6 +460,10 @@ class LinearRegressionSuite extends SparkFunSuite with 
MLlibTestSparkContext {
         // Training results for the model should be available
         assert(model.hasSummary)
     
    +    // Schema should be a superset of the input dataset
    +    assert(model.summary.predictions.schema.fieldNames.toSet ===
    --- End diff --
    
    This may break if we add other output columns.  Can you check for 
containment, instead of equality?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to