Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8798#discussion_r39816093
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
 ---
    @@ -375,7 +377,11 @@ class TungstenAggregationIterator(
             val buffer: UnsafeRow = 
hashMap.getAggregationBufferFromUnsafeRow(groupingKey)
             if (buffer == null) {
               // buffer == null means that we could not allocate more memory.
    --- End diff --
    
    The root cause, we will switch to sort-based aggregation only we don't have 
enough memory, however, the first step of sort-based aggregation is spill, 
which also requires more memory to be allocated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to