Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8843#discussion_r39933300
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -73,7 +76,9 @@ public void loadNext() throws IOException {
numRecordsRemaining--;
if (numRecordsRemaining == 0) {
in.close();
- file.delete();
+ if (!file.delete()) {
+ logger.error("Unable to delete spill file {}", file.getPath());
--- End diff --
Error to me means something unrecoverable; the process can't continue. This
is a warning maybe. It's maybe better to look across the code at places where
`File.delete()` may fail silently and do something similar. And then open a
JIRA for this small cross cutting change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
