Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8843#discussion_r39933628
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
---
@@ -73,7 +76,9 @@ public void loadNext() throws IOException {
numRecordsRemaining--;
if (numRecordsRemaining == 0) {
in.close();
- file.delete();
+ if (!file.delete()) {
+ logger.error("Unable to delete spill file {}", file.getPath());
--- End diff --
That grep assumes the `File` reference name ends in "file". I see 20-30
non-test usages of the method. It may not be worth logging a warning for every
possible failure, but worth surveying the usages to see if any really ought to
log something in case it doesn't delete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
