Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8836#issuecomment-141844411
The changes look good to me. Just want to discuss the semantics to enable
quantiles in output. We set a default value for `quantilesCol`, and use
`quantileProbabilities` to control whether to output quantiles. Another issue
is that `predictQuantiles` requires `quantileProbabilities`. It means in order
to use `predictQuantiles`, we need to append a new column in `transform`. It is
not straightforward to understand the logic here.
I would suggest making `quantilesCol` default to an empty string and ask
users to explicitly set both `quantilesCol` and `quantileProbabilities` to
enable quantile output.
+ @rotationsymmetry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
