Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7753#discussion_r40018396
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -85,6 +85,9 @@ private[spark] class Executor(
         env.blockManager.initialize(conf.getAppId)
       }
     
    +  private val executorMetrics: ExecutorMetrics = new ExecutorMetrics
    +  executorMetrics.setHostname(Utils.localHostName)
    --- End diff --
    
    is the hostname really enough?  What about with multiple executors on the 
same host?  The `Heartbeat` already has the `executorId`, maybe that is all we 
need?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to