Github user liyezhang556520 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7753#discussion_r40301519
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -85,6 +85,9 @@ private[spark] class Executor(
         env.blockManager.initialize(conf.getAppId)
       }
     
    +  private val executorMetrics: ExecutorMetrics = new ExecutorMetrics
    +  executorMetrics.setHostname(Utils.localHostName)
    --- End diff --
    
    It's better to use HOST:PORT, but executor port cannot get here, which 
should get from `RpcEnv.adress.port`. We can get `executorId` on the driver 
side when receiving the message, that might be enough to identify the different 
executors, but since we will show the removed executors on the page, so we 
cannot know where the executor locate by only `executorId`, because the 
Executor tab only shows the active executors. we can remove the hostname here 
if we support showing the removed executors on Executor tab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to