Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8760#issuecomment-142303197
HI @mwws thanks for working on this. I think the overall approach makes
sense, and this will be a big help for users on large clusters. I left some
comments on the code, though I haven't gone through very detailed yet, I tried
to mostly look at a higher level. Once the code is a little closer you'll also
need to add a lot more comments (esp scaladoc on the new interfaces & methods)
and also a lot of tests. But this is looking promising.
btw, I would add "[wip]" (for "work in progress") to the PR title for now,
at least until there are unit tests added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
