Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8760#discussion_r40212790
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -56,8 +56,12 @@ private[spark] abstract class YarnSchedulerBackend(
* This includes executors already pending or running.
*/
override def doRequestTotalExecutors(requestedTotal: Int): Boolean = {
+
+ val nodeBlacklist: Set[String] = scheduler.sc.blacklistTracker
+ .fold(Set.empty[String])(_.nodeBlacklist())
--- End diff --
I know this is normal scala code, but in spark we've decided to adopt a
convention of *not* using `option.fold` -- instead we use
`option.map(...).getOrElse(...)`, or maybe pattern matching depending on the
case. its just a little too confusing for those new to scala.
(you use this in a few other places too, I think)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
