Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/8920#issuecomment-145278471
Hi guys,
I have been playing with different options of implementing this.
1. The first thing I tried is to override arrange twice. Smth like this:
arrange(x, col="Column", ....)
arrange(x, col="character", ..., decreasing=FALSE)
and this is even possible but there are some issues with generating
documentation and finding the corresponding arrange.
2. As next I tried to have the following signature:
arrange(x, col="characterOrColumn", ..., decreasing="logical")
and this is working fine. I had to add additional checks for decreasing
since it is the last parameter. We need to make sure that it is being picked up
correctly.
3. Since orderBy calls arrange we need some modifications there too.
4. and the last thing: I think that having deceasing at the end is not too
bad. R has for base:order a similar signature:
order(..., na.last = TRUE, decreasing = FALSE)
@shivaram @olarayej @sun-rui @felixcheung let me know what do you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
