Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8973#discussion_r41094060
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggregationIterator.scala
---
@@ -131,24 +139,26 @@ abstract class AggregationIterator(
private[this] val nonCompleteAggregateFunctions:
Array[AggregateFunction2] =
allAggregateFunctions.take(nonCompleteAggregateExpressions.length)
- // All non-algebraic aggregate functions with mode Partial,
PartialMerge, or Final.
- private[this] val nonCompleteNonAlgebraicAggregateFunctions:
Array[AggregateFunction2] =
- nonCompleteAggregateFunctions.collect {
- case func: AggregateFunction2 if
!func.isInstanceOf[AlgebraicAggregate] => func
--- End diff --
For instance, here's an example of how changing "non-algebraic" to
"interpreted" can simplify things a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
