Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8973#issuecomment-145306911
Ah, I think that I may see the reason for this now: it appears that the
bufferOffsets in `AggregateFunction2` are not relevant when you're dealing with
`AlgebraicAggregate` instances.
To me, this is further evidence that the current inheritance hierarchy is
wrong: `AlgebraicAggregate` inherits from `AggregateFunction2`, adds a new set
of methods, then effectively bans the use of the inherited methods. This is
really confusing. I think that it's an anti-pattern / bad code smell if you end
up inheriting and wanting to remove methods inherited from the superclass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
