Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8976#discussion_r41130010
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnRMClient.scala ---
    @@ -49,10 +49,11 @@ private[spark] class YarnRMClient(args: 
ApplicationMasterArguments) extends Logg
        *
        * @param conf The Yarn configuration.
        * @param sparkConf The Spark configuration.
    -   * @param preferredNodeLocations Map with hints about where to allocate 
containers.
    +   * @param preferredNodeLocations not used. Left for backward 
compatibility.
        * @param uiAddress Address of the SparkUI.
        * @param uiHistoryAddress Address of the application on the History 
Server.
        */
    +  @deprecated("Passing in preferred locations has no effect at all, see 
SPARK-10921", "1.5.1")
    --- End diff --
    
    Since this is private to spark, I think the method can just change 
signature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to