Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/8976#issuecomment-145925233
  
    ```
    [error]  * method preferredNodeLocationData_=(scala.collection.Map)Unit in 
class org.apache.spark.SparkContext does not have a correspondent in new version
    [error]    filter with: 
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.SparkContext.preferredNodeLocationData_=")
    [error]  * synthetic method <init>$default$6()scala.collection.Map in 
object org.apache.spark.SparkContext does not have a correspondent in new 
version
    [error]    filter with: 
ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.SparkContext.<init>$default$6")
    ```
    
    The first one looks like a false positive. It's noting the removal of the 
synthetic setter for the private var field that was removed, but that's OK 
since it was `private[spark]`. You can just add the suggested exclude to 
`project/MimaExcludes.scala` -- just follow the pattern there, under "1.6".
    
    The second, I'm not so sure. I wonder if it is an obscure complaint about 
the change to the constructors. For example, given the change, I'm not sure I 
can do this anymore? `new SparkContext("master", "appName", 
preferredNodeLocations = Map(...))`? That may be a good point if I have that 
right.
    
    You changed it that way since leaving both with the optional args would not 
compile? Hm. It may be that we have to leave the existing constructor and param 
and just note it does nothing, unless you can see another way to deprecate but 
support any existing invocation, while providing a non-deprecated constructor 
with all the same functionality except `preferredNodeLocations`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to