GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/9006
[SPARK-10966] Codegen framework cleanup
This PR is mostly cosmetic and cleans up some warts in codegen (nearly all
of which were inherited from the original quasiquote version).
- Add lines numbers to errors (in stacktraces when debug logging is on,
and always for compile fails)
- Use a variable for input row instead of hardcoding "i" everywhere
- rename `primitive` -> `value` (since its often actually an object)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marmbrus/spark codegen-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9006
----
commit 7f45249af95d603a4a97ec7be703f9e1c6961b67
Author: Michael Armbrust <[email protected]>
Date: 2015-10-07T01:58:24Z
Codegen cleanup
commit de4a2478b26290f9487311c088e67ebc7b645f8c
Author: Michael Armbrust <[email protected]>
Date: 2015-10-07T02:10:24Z
Merge remote-tracking branch 'origin/master' into codegen-cleanup
Conflicts:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
