Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9006#discussion_r41345699
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -112,21 +115,21 @@ class CodeGenContext {
}
/**
- * Returns the code to access a value in `SpecializedGetters` for a
given DataType.
+ * Returns the specialized code to access a value from `inputRow` at
`ordinal`.
*/
- def getValue(getter: String, dataType: DataType, ordinal: String):
String = {
+ def getValue(inputRow: String, dataType: DataType, ordinal: String):
String = {
--- End diff --
well, "getter" usually means the function itself so this is better IMHO.
If anything it would be "getee" (i.e. the target of getting), but thats weird.
Other suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
